Suse packages #342
Merged
Suse packages #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No idea why someone chose to set all these packages for installation. I can't find any matching nginx.spec on Suse build service plus we don't want to set a specific nginx package version so just use 'nginx' as package.
| @@ -6,7 +6,7 @@ proxy_send_timeout <%= @proxy_send_timeout %>; | |||
| proxy_read_timeout <%= @proxy_read_timeout %>; | |||
| proxy_buffers <%= @proxy_buffers %>; | |||
| proxy_buffer_size <%= @proxy_buffer_size %>; | |||
| proxy_http_version <%= @proxy_http_version %>; | |||
| <%# proxy_http_version <%= @proxy_http_version %><%#; %> | |||
There was a problem hiding this comment.
Would you mind cleaning this up?
|
🆒. Need to get tests passing again. I think it's due to the items that made it into Once fixed up, I'll merge it in. |
|
Yo sorry, missed those. |
|
Ah and there are tests for all the packages, missed those I'll have a go at those quick. |
|
done 🐰 |
|
@globin awesome. 🙇. Thanks for the code. |
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Oct 23, 2017
Suse packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No idea why someone chose to set all these packages for installation.
I can't find any matching nginx.spec on Suse build service plus we don't
want to set a specific nginx package version so just use 'nginx' as package.