fix location sanitizing with parser 'future' #301
Conversation
|
I'm not sure I want to commit this. It's annoying, for sure, but I'd rather track a fix upstream since future-parser is still experimental. I'd love to have conversation about this from the community. |
|
Hmm. I was just about to report this to puppetlabs and came across this one: https://tickets.puppetlabs.com/browse/PUP-1814 I don't think there's anything left to fix in upstream :-) |
With parser 'future', a '\\' counts as one backslash whereas with parser 'current' it's two. Therefore with 'future' only one gets passed to regsubst which in turn aborts with Error: regsubst(): Bad regular expression `\' The 'future' behaviour is indeed the correct one but 'current' won't be fixed either. Therefore, use "\\\\" which produces two backslashes with both parser (ref: https://tickets.puppetlabs.com/browse/PUP-1814).
|
I've updated the PR with a less ugly fix. |
|
same error here. I can confirm the bugfix from @yath is working. I tried to find out, how the guys from https://puphpet.com/ fixed the error. But dont figured it out. |
|
👍 |
|
🆒. Thanks for comments. The streamlined code looks much more palatable. Thanks for the code! ❤️ |
fix location sanitizing with parser 'future'
|
👍 |
fix location sanitizing with parser 'future'
With parser 'future', a '' counts as one backslash whereas with
parser 'current' it's two. Therefore with 'future' only one gets passed
to regsubst which in turn aborts with
Error: regsubst(): Bad regular expression `'
Probably the 'current' behaviour is a bug, as
http://docs.puppetlabs.com/puppet/latest/reference/lang_datatypes.html#single-quoted-strings
states:
When a literal double backslash is intended, a quadruple backslash must
be used.
Yet, fixing either parser will break code so test here if '' is two
characters or one. Clumsy, but works.