Implementation of new vars configtest_enable and service_restart... #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vhosts defined Description: When running first time from scratch, if class was included without any setup at all and with sane defaults, in debian squeeze generates an error when trying to collect non existant vhosts, because cat complains that can not expand * because there are no files. Changed: Added unless to check that at least there is a file in nginx.d by testing it can expand.
…new structure, backwards compatible Defaults are set inside params, nginx class will set default and send it from local var to nginx::config, so even when there is no need for set default values on nginx::config, in case someone already using this module it's for some reason calling directly nginx::config, to avoid breaking anything defaults are set inside nginx::config too.
Added confd_purge option to tell it to purge files non managed by pupet in conf.d, default is false. Because vhost_autogen it's not actually managed by puppet but indirectly created by a puppet executed command, it's added as ignore to avoid getting it removed. Better formating for confd purge support Better formating for confd purge support
…their respective optional arguments. Argument configtest_enable / params.pp $nx_configtest_enable * Default false * If true will set service[nginx] restart with contents of nx_service_restart. Argument service_restart / params.pp $nx_service_restart * Default '/etc/init.d/nginx configtest && /etc/init.d/nginx restart' * Since nginx 0.7.53 nginx supports '-s HUP' which will reload testing configuration first, to be backwards compatible above default was choosen. Many distributions of nginx already implement a configtest before restart, however many doesn't, and many even don't provide restart but a stop/start combination. If configtest_enable is true then puppet will force nginx to do a configtest no matter if it was going or not to do it itself.
jfryman
added a commit
that referenced
this pull request
Oct 2, 2012
Implementation of new vars configtest_enable and service_restart...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Argument configtest_enable / params.pp $nx_configtest_enable
Argument service_restart / params.pp $nx_service_restart
Many distributions of nginx already implement a configtest before restart, however many doesn't, and many even don't provide restart but a stop/start combination. If configtest_enable is true then puppet will force nginx to do a configtest no matter if it was going or not to do it itself.