Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configuration revamp #269

Closed
wants to merge 1 commit into from
Closed

configuration revamp #269

wants to merge 1 commit into from

Conversation

mks-m
Copy link
Contributor

@mks-m mks-m commented Mar 7, 2014

  • make many more things configurable
  • stop using ::params::* for things that are configurable
  • add worker_rlimit_nofile option
  • add tcp_nopush option

@mks-m
configuration revamp
268144e 
- make many more things configurable
- stop using ::params::* for things that are configurable
- add worker_rlimit_nofile option
- add tcp_nopush option
@jfryman
Copy link
Contributor

jfryman commented Mar 10, 2014

Very nice. Would you rebase?

@janorn
Copy link
Contributor

janorn commented May 12, 2014

Is this happening or should I submit a similar pull request? Really need this for good hiera support.

@andyleejordan
Copy link
Contributor

@janorn As is, I've been able to configure everything with Hiera just fine. Are you running into problems?

@janorn
Copy link
Contributor

janorn commented May 12, 2014

You can't configure everything. With this patch you will be able to alter locations of config and many more options. The reference of params in templates makes it impossible to change them from hiera.

This patch is a long way to improve this and I just started on a similar patch. A bit unnecessary if this gets done.

@janorn janorn mentioned this pull request Jun 23, 2014
Merged
@jfryman jfryman closed this Jun 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mks-m @jfryman @janorn @andyleejordan