Bugfix for duplicate listen option caused by hardcoded ipv6only=on in template
#249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 3, 2014 12:54
See jfryman#30
Specs no longer require `ipv6only=on` in listen option when using user supplied value since it is no longer hardcoded in the template.
|
Dig it. 👍 |
jfryman
pushed a commit
that referenced
this pull request
Feb 4, 2014
Bugfix for duplicate listen option caused by hardcoded `ipv6only=on` in template
Closed
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Oct 23, 2017
…ion_ipv6only Bugfix for duplicate listen option caused by hardcoded `ipv6only=on` in template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hardcoded
ipv6only=onlisten option in mailhost.erb, mailhost_ssl.erb, vhost_header.erb and vhost_ssl_header.erb cause nginx to fail:duplicate listen options for [::]:80 in /etc/nginx/sites-enabled/ [...]To avoid this I moved
ipv6only=onfrom the templates into the puppet code. This way it should be backwards compatible if no listen options are passed to the define type.