Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic support for nginx on Solaris. #247

Merged
merged 4 commits into from
Feb 12, 2014
Merged

Conversation

janorn
Copy link
Contributor

@janorn janorn commented Jan 30, 2014

Basic support for Solaris

@jfryman
Copy link
Contributor

jfryman commented Jan 30, 2014

Super cool! Thanks for this!

@jfryman
Copy link
Contributor

jfryman commented Feb 10, 2014

@janorn Did this pass CI for you? Can you take a look at the errors and fix up?

@janorn
Copy link
Contributor Author

janorn commented Feb 11, 2014

I refreshed my fork and now it seems to pass?! Not that I am so familiar with Travis.

@@ -85,6 +88,7 @@
$nx_daemon_user = $::operatingsystem ? {
/(?i-mx:debian|ubuntu)/ => 'www-data',
/(?i-mx:fedora|rhel|redhat|centos|scientific|suse|opensuse|amazon|gentoo|oraclelinux)/ => 'nginx',
/(?i-mx:debian|solaris)/ => 'webservd',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be /(?i-mx:solaris)/

@janorn
Copy link
Contributor Author

janorn commented Feb 12, 2014

Case bug fixed.

jfryman pushed a commit that referenced this pull request Feb 12, 2014
Added basic support for nginx on Solaris.
@jfryman jfryman merged commit 7c99c70 into voxpupuli:master Feb 12, 2014
cegeka-jenkins pushed a commit to cegeka/puppet-nginx that referenced this pull request Oct 23, 2017
Added basic support for nginx on Solaris.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants