Allow a custom nginx.conf source to be defined #241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where configuration complexity or legacy support dictates the need for hand-crafted configuration, allow the user to pass in a file source for nginx.conf. Currently it's possible to use this module and define/manage your own virtual hosts and other configuration. This change will allow the main config to be manually managed as well, but still take advantage of the repo and service management of the module.
|
@Slashbunny would #272 also meet your need? same thing essentially, but also |
|
Yeah, I agree, it's essentially the same thing. It should work fine. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A legacy configuration I was working with recently was very complex. Using vhost and location definitions left me with something more complex and harder to maintain than the original file itself (and twice as long). In some cases, some of the techniques weren't supported at all, or I'd need to implement it differently to get around validations, which was making it all the more complex. I decided to simply move the existing vhost configuration files into place using a
fileresource and notifynginx::service, as this was a much cleaner solution.I find myself in the same situation for the main
nginx.conf, but I don't want to drop use of the module completely, so I created this patch.This may be something you don't want to even merge in or you may want to do it differently. It may be considered out of scope of the module to only use it only for the package and service management. FWIW, I use all parts of this module in other scenarios and it works great, thanks in advance!