Add validation for location $priority #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valid range changed to 401-599: vhost SSL header has priority 700. If $priority is set to 400 (which resolves to 400+300=700 for SSL locations), then it would conflict with the priority of the header. It must be 401 or higher to avoid this. Top end of range is limited to 599 to reflect documentation however it could be increased to 698 and still provide expected behavior.
|
Makes good sense. |
jfryman
pushed a commit
that referenced
this pull request
Jan 6, 2014
Add validation for location $priority
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Oct 23, 2017
Add validation for location $priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Valid range changed to 401-599:
vhost SSL header has priority 700. If $priority is set to 400 (which resolves to 400+300=700 for SSL locations), then it would conflict with the priority of the header. It must be 401 or higher to avoid this.
Top end of range is limited to 599 to reflect documentation however it could be increased to 698 and still provide expected behavior.
Current default priorities:
$ssl_only != true, which is default)$ssl == true). Is$priority + 300.Non-conflicting HTTP location fragment priorities: 002-698. Means
$priorityvalid range is 002-698.Non-conflicting SSL location fragment priorities: 701-998. Means
$priorityvalid range is 401-698.Documentation says valid range is 400-499 and 501-599. This is correct for HTTP but is incorrect for SSL (the range should be 401-499).