Add a new boolean configuration option for copying of SSL certificates.

[hdanes]

Introduced a new option to disable or enable copying SSL related files like certificates, keys, etc.

For example if there is a shared wildcard certificate there are a lot of copies created of the same certificate which will mess up the Nginx configuration folder. As discussed in issue #80 the default system directory should be used.

Example of usage changeset:
class { 'nginx':
copy_ssl_files => false,
}

nginx::resource::vhost { 'name':
ensure => present,
ssl => true,
ssl_cert => '/etc/ssl/certs/file.pem',
ssl_key => '/etc/ssl/certs/file.key',
ssl_dhparam => '/etc/ssl/certs/file.dhparams.pem',
}

The 'copy' option is enabled by default for backward compatibility. It might be a solution to remove this option in one of the upcoming releases.

[CpuID]

+1, this would be awesome to see submitted.

[3flex]

+1

[3flex]

It would be great to have the value validated as a boolean, and also some rspec tests to test the new behaviour.

If the intention is to deprecate the "true" value in future (which I personally agree with) then consider adding a warning to that effect, but that's up to the maintainer.

[hdanes]

I've implemented the validation of the boolean value. Unfortunately I haven't enough time to write the rspec tests at this moment. Is it possible to add them later in a separate pull request?

@jfryman Could you share your opinion about the deprecation warning (see comment of @3flex)?

[CpuID]

Hey Guys,

Any updates to this? bump :)

[jfryman]

@hdanes I agree with @3flex. A deprecation warning would be 👍