Add support for proxy method and body #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dominik Richter <[email protected]>
Signed-off-by: Dominik Richter <[email protected]>
|
Rebased on latest master, since Travis is working again. |
| @@ -8,6 +8,12 @@ | |||
| <% end -%> | |||
| proxy_pass <%= @proxy %>; | |||
| proxy_read_timeout <%= @proxy_read_timeout %>; | |||
| <% if not @proxy_method.nil? -%> | |||
There was a problem hiding this comment.
Just use if @proxy_method (same for @proxy_set_body)
kudos to Matthew Haughton for this suggestion Signed-off-by: Dominik Richter <[email protected]>
|
@3flex Thank you! I updated the PR |
|
Could you also try adding tests for this new functionality? Have a look in |
Signed-off-by: Dominik Richter <[email protected]>
|
@3flex I added specs for both items, thanks again! |
|
Awesome! Thanks for this! |
jfryman
pushed a commit
that referenced
this pull request
Dec 5, 2013
…d_body Add support for proxy method and body
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Oct 23, 2017
…method_and_body Add support for proxy method and body
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for setting proxy method and proxy body.
We found this useful when using nginx to rewrite our requests.
Usage example:
I wasn't sure if and where to add method-specific tests for this ;)
(fyi: The comment in
manifests/resource/location.pplooks a bit out of place, but it's because the others aren't aligned correctly. I'll add a separate MR after this to fix them.)