Fix apt-key deprecated message
#1610
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miluxhd
force-pushed
the
fix/depricated-apt-key
branch
9 times, most recently
from
c326f08 to
e1fa81e
Compare
kenyon
requested changes
Aug 23, 2024
There was a problem hiding this comment.
Can you also update the README to say that at least puppetlabs-apt v9.2.0 is needed? That's the version which added support for "modern keyrings". Here in the readme:
Lines 19 to 21 in 12d6b62
https://github.com/puppetlabs/puppetlabs-apt/blob/main/CHANGELOG.md#v920---2023-12-04
miluxhd
force-pushed
the
fix/depricated-apt-key
branch
2 times, most recently
from
11b0886 to
846f12a
Compare
|
given the "new" version for the dependency, should this be marked backward-incompatible? |
I think yes, because users of this module who use it with puppetlabs-apt would need to update their puppetlabs-apt module. Same as how we've done for this kind of change in other modules. |
kenyon
requested changes
Aug 26, 2024
miluxhd
force-pushed
the
fix/depricated-apt-key
branch
3 times, most recently
from
c3b21b7 to
7037314
Compare
kenyon
requested changes
Aug 27, 2024
miluxhd
force-pushed
the
fix/depricated-apt-key
branch
from
7037314 to
bf1f44e
Compare
miluxhd
force-pushed
the
fix/depricated-apt-key
branch
from
bf1f44e to
0d15067
Compare
kenyon
approved these changes
Aug 27, 2024
This was referenced Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
In the current implementation, apt::source stores GPG keys in the trusted.gpg file, which is no longer recommended. Additionally, with the deprecation of apt-key, running the apt update command triggers warnings on Debian-based distributions.
This PR modifies the handling of GPG keys so that they are stored in the keyrings directory, aligning with best practices and avoiding the deprecation warnings associated with apt-key