Add access and error logs directives when www_to_non_www or non_www_to_www is used
#1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase on latest master to see if all of the checks pass. |
m1keru
force-pushed
the
access_log_in_redirect_location
branch
from
6c0389d to
996ae5e
Compare
Thanks, done |
kenyon
changed the title
www_to_non_www or non_www_to_www is used
kenyon
approved these changes
Jun 24, 2023
|
@m1keru thanks for the PR! the template is quite complex. could you add a unit test that ensures the correct content is rendered? |
m1keru
force-pushed
the
access_log_in_redirect_location
branch
5 times, most recently
from
e6b3482 to
39a08c9
Compare
m1keru
force-pushed
the
access_log_in_redirect_location
branch
5 times, most recently
from
f9e7329 to
48e5006
Compare
m1keru
force-pushed
the
access_log_in_redirect_location
branch
from
48e5006 to
82e024c
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Add access_log and error_log to rewrite sections.
This Pull Request (PR) fixes the following issues
Fixes #1545