apt::source: configure repo only for current architecture

[bastelfreak]

Without this setting, we tell apt to download release information for all architectures apt knows. This includes i386 on amd64 systems. nginx doesn't publish i386 packages. because of that, it results in a warning during apt update:

N: Skipping acquire of configured file 'nginx/binary-i386/Packages' as repository 'https://nginx.org/packages/ubuntu jammy InRelease' doesn't support architecture 'i386'

This is fixed with this change.

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

[puppet-community-rangefinder]

nginx::package::debian is a class

that may have no external impact to Forge modules.

This module is declared in 9 of 580 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[bastelfreak]

This will look like:

Notice: /Stage[main]/Nginx::Package::Debian/Apt::Source[nginx]/Apt::Setting[list-nginx]/File[/etc/apt/sources.list.d/nginx.list]/content:
--- /etc/apt/sources.list.d/nginx.list	2022-12-20 10:44:43.029009469 +0100
+++ /tmp/puppet-file20221220-1147919-1fj17e7	2022-12-20 10:45:04.640920139 +0100
@@ -1,3 +1,3 @@
 # This file is managed by Puppet. DO NOT EDIT.
 # nginx
-deb https://nginx.org/packages/ubuntu jammy nginx
+deb [arch=amd64] https://nginx.org/packages/ubuntu jammy nginx

Notice: /Stage[main]/Nginx::Package::Debian/Apt::Source[nginx]/Apt::Setting[list-nginx]/File[/etc/apt/sources.list.d/nginx.list]/content: current_value '{sha256}827157dcc30574434a3993b56d28624f144469d9e55d7749aaa6aad338ee5749', should be '{sha256}bd83793d6907c903d5701add41c2f046bf70300f8d3c8590523dd6ccc6decef6' (noop)
Notice: Apt::Setting[list-nginx]: Would have triggered 'refresh' from 1 event
Notice: Apt::Source[nginx]: Would have triggered 'refresh' from 1 event

[smortex]

Without this setting, we tell apt to download release information for all architectures apt knows.

"apt knows" or "apt is configured to use" 😉. I had similar "issue" at a customer running Ubuntu, and preferred to dpkg --remove-architecture i386 because that made no sense on their system.

They could not say if the added it or if Ubuntu was shipping with this by default.