Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RedHat 8 #1506

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Conversation

stevenzerbe
Copy link
Contributor

Pull Request (PR) description

Enable RHEL8 operatingsystem_support

This Pull Request (PR) fixes the following issues

@puppet-community-rangefinder
Copy link

nginx::package::redhat is a class

that may have no external impact to Forge modules.

nginx::params is a class

Breaking changes to this file MAY impact these 1 modules (near match):

This module is declared in 9 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@stevenzerbe
Copy link
Contributor Author

@ghoneycutt requested I ping them for review.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add CentOS 8 to the list of supported OSes. That gives us acceptance tests.

@stevenzerbe
Copy link
Contributor Author

CentOS 8 added to operatingsystem_support for testing.

@ghoneycutt ghoneycutt merged commit f11ef6a into voxpupuli:master Aug 10, 2022
@ghoneycutt
Copy link
Member

Merged as the spec tests are passing and the failing acceptance tests were already failing and are unrelated to this change.

@smortex
Copy link
Member

smortex commented Aug 11, 2022

FYI, the passenger repo is really not working on CentOS Stream:

Error: 
 Problem: cannot install the best candidate for the job
  - nothing provides rubygem(rack) needed by passenger-6.0.14-1.el8.x86_64
(try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages)

Will remove support for it in #1502 (where I am attempting to fix CI).

@smortex smortex added the enhancement New feature or request label Aug 24, 2022
@smortex smortex changed the title Add RedHat 8 Add support for RedHat 8 Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants