Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch away from os.distro.codename fact #1498

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Switch away from os.distro.codename fact #1498

merged 1 commit into from
Mar 15, 2022

Conversation

root-expert
Copy link
Member

Pull Request (PR) description

Releated info: voxpupuli/beaker-hostgenerator#244

This Pull Request (PR) fixes the following issues

@puppet-community-rangefinder
Copy link

nginx::params is a class

Breaking changes to this file MAY impact these 1 modules (near match):

This module is declared in 9 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

manifests/params.pp Outdated Show resolved Hide resolved
@root-expert
Copy link
Member Author

I guess we have to wait for my PR on puppetlabs-apt to get merged before merging this.

@kenyon
Copy link
Member

kenyon commented Feb 25, 2022

Anything related to EoL Ubuntu 16.04 could also just be removed I think.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ekohl ekohl merged commit 6e7596a into master Mar 15, 2022
@ekohl ekohl deleted the safe-facts branch March 15, 2022 12:20
@ekohl ekohl added the bug Something isn't working label Mar 15, 2022
@ekohl
Copy link
Member

ekohl commented Mar 15, 2022

Anything related to EoL Ubuntu 16.04 could also just be removed I think.

In the short term, this improves things without having to do a major release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants