Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mime types with upstream #1482

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Conversation

adriankirchner
Copy link
Contributor

Pull Request (PR) description

Update default mime types with current upstream at https://github.com/nginx/nginx/blob/3334585539168947650a37d74dd32973ab451d70/conf/mime.types

@puppet-community-rangefinder
Copy link

nginx::params is a class

that may have no external impact to Forge modules.

This module is declared in 9 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@kenyon kenyon merged commit 1b738ae into voxpupuli:master Nov 3, 2021
@ekohl
Copy link
Member

ekohl commented Nov 3, 2021

Just a general thought: in RH-based distros there's /etc/mime.types provided by mailcap and on Debian-based there's /etc/mime.types provided by media-types. Can't we just use those rather than having this massive data entry?

@kenyon
Copy link
Member

kenyon commented Nov 3, 2021

@ekohl I would rather just leave the file alone and use what’s installed by the distribution package, e.g., in nginx-common on Debian.

@ekohl
Copy link
Member

ekohl commented Nov 3, 2021

Well, that's pretty much my point: do we need to manage this at all?

@adriankirchner
Copy link
Contributor Author

My guess is that you can't source /etc/mime.types to nginx because of different syntax.

I would rather just leave the file alone and use what’s installed by the distribution package, e.g., in nginx-common on Debian.

That would be fine, but as a user of puppet-nginx I want to be able to add more mime types if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants