Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default ipv6_listen_port to listen_port #1456

Merged
merged 2 commits into from
May 28, 2021
Merged

Conversation

bastelfreak
Copy link
Member

in 99% of the deployments both ports are identical. to make this easier
for the users we can just tell puppet that the default value for
$ipv6_listen_port is the value of $listen_port. That makes it easier for
people that want their dual stack application to listen on a nonstandard
port. They only need to set it once.

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@bastelfreak bastelfreak added the enhancement New feature or request label May 26, 2021
@bastelfreak bastelfreak self-assigned this May 26, 2021
@puppet-community-rangefinder
Copy link

nginx::resource::mailhost is a type

that may have no external impact to Forge modules.

nginx::resource::server is a type

Breaking changes to this file WILL impact these 13 modules (exact match):
Breaking changes to this file MAY impact these 4 modules (near match):

nginx::resource::streamhost is a type

that may have no external impact to Forge modules.

This module is declared in 9 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@kenyon
Copy link
Member

kenyon commented May 26, 2021

I'm approving the idea, of course need passing tests ;)

in 99% of the deployments both ports are identical. to make this easier
for the users we can just tell puppet that the default value for
$ipv6_listen_port is the value of $listen_port. That makes it easier for
people that want their dual stack application to listen on a nonstandard
port. They only need to set it once.
@bastelfreak bastelfreak merged commit ffa5ad9 into voxpupuli:master May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants