Unify (http_)log_format in nginx class and server resource

[TuningYourCode]

Pull Request (PR) description

This PR unifies nginx::http_log_format and nginx::resource::server::log_format that the later defaults to the generic set default value.

If no generic default value is set nginx itself will default to the "old" default value of "combined" (see http://nginx.org/en/docs/http/ngx_http_log_module.html#access_log)

As there are already tests which test the behavior of nginx::http_log_format and nginx::resource::server::log_format there were no additional tests added.

This Pull Request (PR) fixes the following issues

Relates #773

[puppet-community-rangefinder]

nginx is a class

Breaking changes to this file WILL impact these 14 modules (exact match):

• dhollinger-devopsdays
• eelcomaljaars-friendica
• kalfa-sites
• samuelson-custom_webapp
• akisakye-matomo
• othalla-nextcloud
• jonhallettuob-existdb
• stackstorm-st2
• pgassmann-letsencrypt_nginx
• cristifalcas-kibana
• geoffwilliams-r_profile
• covata-safeshare
• ploperations-webhook_proxy
• landcareresearch-ckan

Breaking changes to this file MAY impact these 34 modules (near match):

• jmkeyes-netbox
• lboynton-gitlab
• klynton-testing
• nicopaez-dockerserver
• pltraining-selfpaced
• jbussdieker-graphite_web
• aursu-grayloginstall
• 4n0m4l0u5-configure_nginx
• ramiel-owncloud
• dmexe-deploy
• firm1-zds
• danieldreier-puppet_installer
• qroac-isp3node
• adcade-statsd
• compass-learninglocker
• compass-examdb
• vormetriclabs-meteor
• chedi-django
• nicopaez-alfred
• nicopaez-triage
• tracywebtech-appdeploy
• puppetfinland-patchwork
• ploperations-puppet
• mightp-librenms
• vshn-uhosting
• qtechnologies-psgi
• maestrodev-maestro_nodes
• puppetfinland-freight
• oris-appserver
• SchnWalter-happydev
• groupbuddies-gb
• halyard-boxen
• mtulio-profiles
• braiins-wordpressnginx

nginx::resource::server is a type

Breaking changes to this file WILL impact these 13 modules (exact match):

• kalfa-sites
• samuelson-custom_webapp
• akisakye-matomo
• jonhallettuob-existdb
• ploperations-webhook_proxy
• pgassmann-letsencrypt_nginx
• geoffwilliams-r_profile
• covata-safeshare
• aursu-gitlabinstall
• aursu-dockerinstall
• dhollinger-devopsdays
• othalla-nextcloud
• stackstorm-st2

Breaking changes to this file MAY impact these 4 modules (near match):

• aursu-grayloginstall
• 4n0m4l0u5-configure_nginx
• mightp-librenms
• qroac-isp3node

This module is declared in 9 of 576 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[bastelfreak]

thanks for the PR!