Use more restrictive mode on temp paths #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I get this on each run here: Notice: /Stage[main]/Nginx::Config/File[/run/nginx/client_body_temp]/mode: mode changed '0700' to '0755' Notice: /Stage[main]/Nginx::Config/File[/run/nginx/proxy_temp]/mode: mode changed '0700' to '0755' It seems like nginx and this module have different opinions on the correct mode for those directories. I believe Nginx is more correct, and we should therefore follow it. Note that this might apply to your module only if you have a global File default resource defined. Closes: voxpupuli#1272
nginx::config is a classBreaking changes to this file MAY impact these 2 modules (near match):This module is declared in 9 of 576 indexed public
|
kenyon
approved these changes
Feb 2, 2021
ekohl
approved these changes
Feb 2, 2021
alexjfisher
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I get this on each run here:
Notice: /Stage[main]/Nginx::Config/File[/run/nginx/client_body_temp]/mode: mode changed '0700' to '0755'
Notice: /Stage[main]/Nginx::Config/File[/run/nginx/proxy_temp]/mode: mode changed '0700' to '0755'
It seems like nginx and this module have different opinions on the
correct mode for those directories. I believe Nginx is more correct,
and we should therefore follow it.
Note that this might apply to your module only if you have a global
File default resource defined.
Fixes: #1272