Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added class param to disable YUM repo management on RedHat platforms #144

Merged
merged 2 commits into from
Oct 7, 2013

Conversation

rytis
Copy link
Contributor

@rytis rytis commented Sep 26, 2013

I've added an extra class param to disable repository management. Right now the code only has been modified for RedHat based platforms.

@deric
Copy link
Contributor

deric commented Sep 29, 2013

I've suggested something similar in #145 for Debian: add parameter $nginx::package_source which can have e.g. values nginx, distribution or something else to distinguish source from which is package installed.

@rytis
Copy link
Contributor Author

rytis commented Sep 30, 2013

Would it also allow to disable repository management altogether? For example in my environment the repositories aren't managed by Puppet at all, so it would be nice to be able to disable this functionality.

@jfryman
Copy link
Contributor

jfryman commented Oct 3, 2013

This is a good pattern. I'd like to use this for sure.

gpgcheck => '1',
priority => '1',
gpgkey => 'http://nginx.org/keys/nginx_signing.key',
if $nginx::manage_repo {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reasoning for calling the out-of-scope variable?

I almost prefer an tell-don't-ask approach versus ask-don't-tell. Thoughts?

@rytis
Copy link
Contributor Author

rytis commented Oct 7, 2013

Makes sense, I've now patched it so that the param is pushed down all the way to the package.pp and package/redhat.pp.

@jfryman jfryman merged commit b6ee1e5 into voxpupuli:master Oct 7, 2013
@jfryman
Copy link
Contributor

jfryman commented Oct 7, 2013

Awesome. Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants