Simplify service class #1414
Merged
Simplify service class #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nginx::service is a classBreaking changes to this file MAY impact these 1 modules (near match):This module is declared in 10 of 575 indexed public
|
This was referenced Aug 31, 2020
ekohl
force-pushed
the
simplify-service
branch
2 times, most recently
from
aa69fe3 to
49f5b89
Compare
bastelfreak
approved these changes
Aug 31, 2020
igalic
approved these changes
Aug 31, 2020
ekohl
force-pushed
the
simplify-service
branch
from
49f5b89 to
e958dce
Compare
bastelfreak
approved these changes
Aug 31, 2020
It's valid to pass in undef values. That makes the OpenBSD check
redundant. The same goes for the restart command. That removes
pretty much all logic so there is no more benefit to having class
parameters. That's why it now uses all the variables directly from the
nginx class. The has{status,restart} parameters default to true since
Puppet 2.7 so can be removed.
ekohl
force-pushed
the
simplify-service
branch
from
e958dce to
ede91a6
Compare
|
And now with a fix to make rubocop happy. |
bastelfreak
approved these changes
Aug 31, 2020
|
Finally green! That took too many tries for such a simple PR :P |
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
Simplify service class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's valid to pass in undef values. That makes the OpenBSD check redundant. The same goes for the restart command. That removes pretty much all logic so there is no more benefit to having class parameters. That's why it now uses all the variables directly from the nginx class. The has{status,restart} parameters default to true since Puppet 2.7 so they can be removed.
Replaces #1209