Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually use the ensure parameter for mailhost resource to provide absent support #1395

Merged
merged 1 commit into from
Jul 17, 2020
Merged

Actually use the ensure parameter for mailhost resource to provide absent support #1395

merged 1 commit into from
Jul 17, 2020

Conversation

qs5779
Copy link
Contributor

@qs5779 qs5779 commented Jul 16, 2020

Pull Request (PR) description

Apply the mailhost resource parameter ensure to the concat resource.

This Pull Request (PR) fixes the following issues

Fixes #1394

…ent support.

Corretly test that concat resource parameter ensure is absent.
@puppet-community-rangefinder
Copy link

nginx::resource::mailhost is a type

that may have no external impact to Forge modules.

This module is declared in 11 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@ekohl ekohl changed the title Actualy use the ensure parameter for mailhost resource to provide absent support Actually use the ensure parameter for mailhost resource to provide absent support Jul 17, 2020
@ekohl
Copy link
Member

ekohl commented Jul 17, 2020

Failure on EL7 is unrelated, merging.

@ekohl ekohl merged commit f2cb723 into voxpupuli:master Jul 17, 2020
@ekohl ekohl added the bug Something isn't working label Jul 17, 2020
@qs5779 qs5779 deleted the support_absent_mailhosts branch July 17, 2020 11:00
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this pull request Oct 19, 2020
…osts

Actually use the ensure parameter for mailhost resource to provide absent support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mailhost resource does not use ensure parameter, therefore cannot be made absent
2 participants