Drop Debian 8 support #1384
Merged
Drop Debian 8 support #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's currently in extended support time and even that ends in about a month.
ekohl
reviewed
May 4, 2020
| @@ -121,8 +121,7 @@ | |||
| 'passenger_package_name' => 'libnginx-mod-http-passenger', | |||
| 'include_modules_enabled' => true, | |||
| } | |||
| } elsif ($facts['os']['name'] == 'ubuntu' and $facts['os']['distro']['codename'] in ['lucid', 'precise', 'trusty', 'xenial']) | |||
| or ($facts['os']['name'] == 'debian' and $facts['os']['release']['major'] in ['6', '7', '8']) { | |||
| } elsif ($facts['os']['name'] == 'ubuntu' and $facts['os']['distro']['codename'] in ['lucid', 'precise', 'trusty', 'xenial']) { | |||
There was a problem hiding this comment.
Isn't lucid AFAIK only Xenial is supported here. However, I'd argue we should just drop this and never manage the repo by default. Just trust the OS versions and leave it up to users.
There was a problem hiding this comment.
I had the same in mind, but I guess it should be handled in a different PR
There was a problem hiding this comment.
Perhaps that should be done first to keep this PR smaller (and the other really focused on just dropping that).
ekohl
reviewed
May 4, 2020
| @@ -11,7 +11,7 @@ def location_for(place, fake_version = nil) | |||
| end | |||
|
|
|||
| group :test do | |||
| gem 'voxpupuli-test', '>= 1.0.0', :require => false | |||
| gem 'voxpupuli-test', '>= 1.4.0', :require => false | |||
There was a problem hiding this comment.
I know, I wanted a hotfix to get master green again. I will have a look at modulesync_config later :)
ekohl
approved these changes
May 5, 2020
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
Drop Debian 8 support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's currently in extended support time and even that ends in about a
month.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues