Fix rewrite_non_www_to_www when using SSL #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! Adding a spec test will give VP members the confidence to merge this. |
|
Ping @simmerz (author of the initial PR) for review. |
This part seems to be missing from the original patch to add support for rewrite_non_www_to_www (4b2b108). It was added to the non-SSL template but missing from the SSL template.
smortex
force-pushed
the
fix-ssl-rewrite_non_www_to_www
branch
from
0bd6465 to
d336a0e
Compare
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
…w_to_www Fix rewrite_non_www_to_www when using SSL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This part seems to be missing from the original patch to add support for
rewrite_non_www_to_www(4b2b108).It was added to the non-SSL template but missing from the SSL template.
This Pull Request (PR) fixes the following issues
n/a (no issue reported)