Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manage repo for Debian 10 #1344

Merged
merged 5 commits into from
Jan 7, 2020
Merged

manage repo for Debian 10 #1344

merged 5 commits into from
Jan 7, 2020

Conversation

octomike
Copy link
Contributor

Pull Request (PR) description

Nginx official repo supports Debian 10, see here: http://nginx.org/packages/debian/dists/

This Pull Request (PR) fixes the following issues

Systems that upgraded to buster already are not receiving updates for nginx right now.

Copy link
Member

@Dan33l Dan33l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @octomike since this module is not declared debian10 compatible, we need to make all required.
Please:

  • update metadata.json, this will enable unit tests on debian10
  • update acceptance tests to run debian10 (only Puppet6 for the moment, Puppet 5 AIO package is not yet provided by Puppet)

@bastelfreak bastelfreak added enhancement New feature or request needs-work not ready to merge just yet labels Sep 24, 2019
@bastelfreak
Copy link
Member

@octomike ping :)

@anarcat
Copy link
Contributor

anarcat commented Oct 31, 2019

i can confirm that this module works on Debian 10, for what that's worth.

@pccibot
Copy link

pccibot commented Oct 31, 2019

Dear @octomike, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

2 similar comments
@pccibot
Copy link

pccibot commented Oct 31, 2019

Dear @octomike, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@pccibot
Copy link

pccibot commented Oct 31, 2019

Dear @octomike, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@bastelfreak
Copy link
Member

@octomike can you please rebase?

@vox-pupuli-tasks
Copy link

Dear @octomike, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@vox-pupuli-tasks
Copy link

Dear @octomike, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@bastelfreak
Copy link
Member

@octomike can you add the acceptance tests for debian 10 to the .travis.yml and also add Debian 10 in the metadata.json?

@octomike
Copy link
Contributor Author

octomike commented Jan 6, 2020

Yes, I'm testing this right now and will push the changes later.

@octomike octomike changed the title manage repo for Debian 10 WIP: manage repo for Debian 10 Jan 6, 2020
@octomike
Copy link
Contributor Author

octomike commented Jan 6, 2020

Just so I understand things: For .sync.yml to generate a fresh .travis.yml someone needs to run modulesync (ideally including voxpupuli/modulesync_config#627) on this repo and commit. Is that correct?

@bastelfreak
Copy link
Member

the process is a bit, uhm, not perfect. So msync parses the .sync.yml and generates the acceptance test entries in .travis.yml. Issue here is that we need those tests to pass before we merge this PR. you can just copy and paste the current debian9 blocks in the .travis.yml and rename them to debian10. That will do it for now.

@octomike octomike changed the title WIP: manage repo for Debian 10 manage repo for Debian 10 Jan 7, 2020
@bastelfreak bastelfreak removed the needs-work not ready to merge just yet label Jan 7, 2020
@bastelfreak bastelfreak merged commit 978032e into voxpupuli:master Jan 7, 2020
@octomike octomike deleted the patch-1 branch January 7, 2020 16:14
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this pull request Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants