-
-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rewrite_non_www_to_www option #1326
Conversation
nginx::resource::server is a typeThe enclosing module is declared in 9 of 575 indexed public Puppetfiles. Breaking changes to this file WILL impact these modules (exact match):
Breaking changes to this file MAY impact these modules (near match): These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report. Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should fail to compile if both rewrite_
options are true?
I'll update the PR. Great idea. |
That's pushed @ekohl - thanks for the feedback! |
Add rewrite_non_www_to_www option
Add rewrite_non_www_to_www option
Pull Request (PR) description
This adds the opposing configuration to
rewrite_www_to_non_www
. Many site owners prefer (and this is not to get into the discussion of who is right or wrong) site urls to beginwww.
but also want a rewrite from non-www.
for SEO purposes.This PR adds
rewrite_non_www_to_www
, defaulting to false as per the existing param.