Allow setting a custom path for mime.types #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacksgt
force-pushed
the
mime-types-path
branch
2 times, most recently
from
3e8194d to
aee879f
Compare
ekohl
approved these changes
Mar 11, 2019
There was a problem hiding this comment.
I think the built in default is also a relative path so I think it makes sense. I have suggested one change so that if it's a string, we at least ensure it's not empty. That would probably result in an invalid config.
Edit: an alternative would be to handle empty strings in the if condition.
jacksgt
force-pushed
the
mime-types-path
branch
5 times, most recently
from
5df3ca2 to
ff5ae5e
Compare
In certain environment the user may wish to use mime.types file from a path other than $conf_dir
jacksgt
force-pushed
the
mime-types-path
branch
from
ff5ae5e to
21d6d36
Compare
ekohl
approved these changes
Mar 12, 2019
|
I'll let Travis continue testing, but it looks good to me. If anyone else sees it before I get back to it: just merge it :) |
|
Ping. |
|
Gitlab has a feature 'merge when tests pass'. I miss that here because as you can see, I tend to forget. |
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Sep 13, 2019
Allow setting a custom path for mime.types
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
Allow setting a custom path for mime.types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain environment the user may wish to use mime.types file from
a path other than $conf_dir.
For example when using
conf_dir => '/mnt/gluster/nginx'and mounting the path into a container at/etc/nginx.The module needs to know the 'real' configuration path because it has to write the files there, but at the same time it can't use this path to substitute the absolute path of the mime.types file, because it is at a different location in the container (here:
/mnt/gluster/nginx/mime.typesvs./etc/nginx/mime.types)