Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip line endings in mime.types #1252

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Oct 1, 2018

This ensures there are no empty lines in the file.

This ensures there are no empty lines in the file.
@ekohl ekohl mentioned this pull request Oct 1, 2018
@alexjfisher
Copy link
Member

Is this just cosmetic, or is it a bug to have empty lines? (eg. does nginx complain?)

@ekohl
Copy link
Member Author

ekohl commented Oct 1, 2018

AFAIK cosmetic but I thought it was really ugly to have an empty line below every single line:

# MANAGED BY PUPPET
types {
    text/html html htm shtml;

    text/css css;

    text/xml xml;

    image/gif gif;

@alexjfisher
Copy link
Member

@ekohl Cool. I guess this makes this an 'enhancement' then.

@alexjfisher alexjfisher added the enhancement New feature or request label Oct 1, 2018
@ekohl
Copy link
Member Author

ekohl commented Oct 1, 2018

That sounds correct

@alexjfisher alexjfisher merged commit 5779a42 into voxpupuli:master Oct 1, 2018
@ekohl ekohl deleted the line-endings branch October 1, 2018 12:12
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this pull request Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants