Add service_enable and simplify service_ensure, #1208 #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think the travis failure has anything to do with this PR? |
ekohl
reviewed
May 20, 2018
| @@ -151,6 +151,7 @@ | |||
|
|
|||
| ### START Service Configuation ### | |||
| $service_ensure = running, | |||
| $service_enable = true, | |||
There was a problem hiding this comment.
Should this be a Boolean as well?
ceonizm
pushed a commit
to ceonizm/puppet-nginx
that referenced
this pull request
Jan 23, 2019
ceonizm
pushed a commit
to ceonizm/puppet-nginx
that referenced
this pull request
Jan 23, 2019
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Sep 13, 2019
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Sep 13, 2019
Add service_enable and simplify service_ensure, voxpupuli#1208
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
Add service_enable and simplify service_ensure, voxpupuli#1208
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Adds an explicit $service_enable parameter. Sets to undef by default, which then follows the previous behaviour of auto-setting from $service_ensure.
This replaces a previous effort #1211
This Pull Request (PR) fixes the following issues
Fixes #1208