Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme: listen_port is integer for Hiera #1205

Merged
merged 1 commit into from
Apr 20, 2018
Merged

Update readme: listen_port is integer for Hiera #1205

merged 1 commit into from
Apr 20, 2018

Conversation

AranVinkItility
Copy link
Contributor

@AranVinkItility AranVinkItility commented Apr 17, 2018

Pull Request (PR) description

Fix readme example for streamhosts using Hiera. It incorrectly states that listen_port is a string value when using hiera.

This Pull Request (PR) fixes the following issues

Using the example hiera data for streamhosts gives the following error:

[root@nginxlbmasters /]# puppet agent -t
Info: Using configured environment 'kubernetes'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Retrieving locales
Info: Loading facts
Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Nginx::Resource::Streamhost[kubernetes-api-streamhost]: parameter 'listen_port' expects an Integer value, got String (file: /etc/puppetlabs/code/environments/kubernetes/modules/nginx/manifests/init.pp, line: 181) on node nginxlbmasters.dkkiwezbbzwezjsuf2qq5optbd.ax.internal.cloudapp.net

@alexjfisher alexjfisher added the docs Improvements or additions to documentation label Apr 20, 2018
@alexjfisher alexjfisher merged commit 250300a into voxpupuli:master Apr 20, 2018
@alexjfisher
Copy link
Member

@AranVinkItility Thanks!

cegeka-jenkins pushed a commit to cegeka/puppet-nginx that referenced this pull request Sep 13, 2019
Update readme: listen_port is integer for Hiera
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this pull request Oct 19, 2020
Update readme: listen_port is integer for Hiera
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants