Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add Archlinux acceptance tests #1201

Closed
wants to merge 2 commits into from

Conversation

bastelfreak
Copy link
Member

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@bastelfreak bastelfreak added the needs-work not ready to merge just yet label Mar 24, 2018
@bastelfreak bastelfreak force-pushed the archlinux branch 2 times, most recently from adb7657 to c21bd83 Compare March 25, 2018 00:17
@bastelfreak
Copy link
Member Author

.travis.yml Outdated
- rvm: 2.4.3
bundler_args: --without development release
dist: trusty
env: PUPPET_INSTALL_TYPE=foss BEAKER_debug=true BEAKER_set=docker/archlinux-4 CHECK=beaker
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type=foss needs to be an option in .sync.yml or the next modulesync will override it.

it 'comes from the expected source' do
pkg_output = shell(pkg_cmd)
expect(pkg_output.stdout).to match pkg_match
# the passenger people package ngin, except for Debian 9 systems!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer needed because the other PR has a better fix.

@bastelfreak bastelfreak force-pushed the archlinux branch 3 times, most recently from 01d095a to ed4071b Compare September 15, 2018 10:03
@bastelfreak
Copy link
Member Author

bastelfreak commented Sep 23, 2018

Hi people,
So this currently fails because of wrong defaults. beaker assumes the wrong paths for Puppet. They are based on these defaults:

https://github.com/puppetlabs/beaker-puppet/blob/b0c6608a7ea3060464807ce501060924b0fb7657/lib/beaker-puppet/install_utils/foss_defaults.rb#L73-L90

It seems like the archlinux docker image gets the defaults for unix, not for archlinux. I've no idea where this is coming from :(

@bastelfreak
Copy link
Member Author

Beaker is pretty broken for archlinux support, so I'm going to close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase needs-work not ready to merge just yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants