add etag support at the http level #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhollinger
approved these changes
Feb 26, 2018
alexjfisher
requested changes
Feb 26, 2018
templates/conf.d/nginx.conf.erb
Outdated
| @@ -96,6 +96,10 @@ http { | |||
| lingering_timeout <%= @lingering_timeout %>; | |||
| tcp_nodelay <%= @http_tcp_nodelay %>; | |||
|
|
|||
| <% if defined? @etag -%> | |||
There was a problem hiding this comment.
<% if @etag -%> is fine here since etag is either undef or a yes\no string, not a boolean.
There was a problem hiding this comment.
Sure thing. I just pushed a fix for this, along with a small formatting change for the whitespace so the config file will not get an extra newline when no value is set.
bryangwilliam
force-pushed
the
etag_support
branch
from
c9d6d93 to
4e9cd6e
Compare
ekohl
approved these changes
Feb 26, 2018
wyardley
approved these changes
Feb 26, 2018
alexjfisher
approved these changes
Feb 26, 2018
|
@bryangwilliam Thanks! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Sep 13, 2019
add etag support at the http level
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
add etag support at the http level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for enabling/disabling the etag nginx directive in the http context. http://nginx.org/en/docs/http/ngx_http_core_module.html#etag
If no value is supplied it will not add anything and allow the nginx-defined default to take effect.