Add proxy send timeout for the nginx server configuration. #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eputnam
requested changes
Feb 26, 2018
manifests/resource/server.pp
Outdated
| @@ -25,6 +25,7 @@ | |||
| # [*proxy*] - Proxy server(s) for the root location to connect to. Accepts a single value, can be used in | |||
| # conjunction with nginx::resource::upstream | |||
| # [*proxy_read_timeout*] - Override the default the proxy read timeout value of 90 seconds | |||
| # [*proxy_send_timeout*] - Override the default the proxy read timeout value of 90 seconds | |||
There was a problem hiding this comment.
I'm assuming this should read: "Override the default proxy send timeout value of 90 seconds"?
|
yes this is a type let me fix it and push again.
…On Mon, Feb 26, 2018 at 11:11 AM, Eric Putnam ***@***.***> wrote:
***@***.**** requested changes on this pull request.
LGTM, just a little typo
------------------------------
In manifests/resource/server.pp
<#1181 (comment)>
:
> @@ -25,6 +25,7 @@
# [*proxy*] - Proxy server(s) for the root location to connect to. Accepts a single value, can be used in
# conjunction with nginx::resource::upstream
# [*proxy_read_timeout*] - Override the default the proxy read timeout value of 90 seconds
+# [*proxy_send_timeout*] - Override the default the proxy read timeout value of 90 seconds
I'm assuming this should read: "Override the default proxy send timeout
value of 90 seconds"?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1181 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AfgGdvgtPBkx81Iu__OBpJXvn16Bgxw0ks5tYkQQgaJpZM4SQY74>
.
|
Nitish-SH
commented
Feb 26, 2018
Nitish-SH
commented
Feb 26, 2018
| @@ -24,7 +24,8 @@ | |||
| # [*autoindex*] - Set it on 'on' or 'off 'to activate/deactivate autoindex directory listing. Undef by default. | |||
| # [*proxy*] - Proxy server(s) for the root location to connect to. Accepts a single value, can be used in | |||
| # conjunction with nginx::resource::upstream | |||
| # [*proxy_read_timeout*] - Override the default the proxy read timeout value of 90 seconds | |||
| # [*proxy_read_timeout*] - Override the default proxy read timeout value of 90 seconds | |||
There was a problem hiding this comment.
the message is now changed to "Override the default proxy read timeout value of 90 seconds"
Nitish-SH
commented
Feb 26, 2018
| @@ -24,7 +24,8 @@ | |||
| # [*autoindex*] - Set it on 'on' or 'off 'to activate/deactivate autoindex directory listing. Undef by default. | |||
| # [*proxy*] - Proxy server(s) for the root location to connect to. Accepts a single value, can be used in | |||
| # conjunction with nginx::resource::upstream | |||
| # [*proxy_read_timeout*] - Override the default the proxy read timeout value of 90 seconds | |||
| # [*proxy_read_timeout*] - Override the default proxy read timeout value of 90 seconds | |||
There was a problem hiding this comment.
the message is now changed to "Override the default proxy send timeout value of 90 seconds"
|
should i create new pull request for the typo fixes? |
eputnam
approved these changes
Feb 26, 2018
|
thanks @Nitish-SH ! |
bastelfreak
changed the title
bastelfreak
changed the title
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
Adding proxy send timeout for the nginx server configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.