-
-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance distro support #1154
Enhance distro support #1154
Conversation
I wonder if it would maybe be better to approach this just with another case in params (or with data in modules if #1155 gets merged? |
manifests/package/debian.pp
Outdated
@@ -40,13 +41,15 @@ | |||
location => "https://nginx.org/packages/${distro}", | |||
repos => 'nginx', | |||
key => {'id' => '573BFD6B3D8FBC641079A6ABABF5BD827BD9BF62'}, | |||
release => pick($release, $::lsbdistcodename), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can actually pass undef
to puppetlabs-apt and let the module handle it meaning you don't need to pick: using $release
will just work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, changed in b85c060
We should also add debian 9 to the acceptance test matrix if this is now working. |
@fnoop can you please rebase? |
Closing via #1200; thanks for the contribution. |
Apologies wasn't able to find time to rebase and finish this off, thanks for doing it :) |
Add explicit Debian 9 (stretch) support, and add support for Ubilinux.
Ubilinux 4 (that supports all variants of the Up boards) is a derivative of Debian 9. However it reports dolcetto as the lsbdistcodename instead of stretch so the nginx repo fails. This PR adds support for a $nginx::repo_release parameter that allows the distro code name to be specified rather than blindly taking it from lsbdistcodename.
See:
voxpupuli/puppet-nodejs#342