Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance distro support #1154

Closed
wants to merge 4 commits into from
Closed

Enhance distro support #1154

wants to merge 4 commits into from

Conversation

fnoop
Copy link
Contributor

@fnoop fnoop commented Nov 18, 2017

Add explicit Debian 9 (stretch) support, and add support for Ubilinux.

Ubilinux 4 (that supports all variants of the Up boards) is a derivative of Debian 9. However it reports dolcetto as the lsbdistcodename instead of stretch so the nginx repo fails. This PR adds support for a $nginx::repo_release parameter that allows the distro code name to be specified rather than blindly taking it from lsbdistcodename.

    class { 'nginx':
        manage_repo     => true,
        repo_release    => "stretch",
    }

See:
voxpupuli/puppet-nodejs#342

@wyardley
Copy link
Collaborator

I wonder if it would maybe be better to approach this just with another case in params (or with data in modules if #1155 gets merged?

@@ -40,13 +41,15 @@
location => "https://nginx.org/packages/${distro}",
repos => 'nginx',
key => {'id' => '573BFD6B3D8FBC641079A6ABABF5BD827BD9BF62'},
release => pick($release, $::lsbdistcodename),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can actually pass undef to puppetlabs-apt and let the module handle it meaning you don't need to pick: using $release will just work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, changed in b85c060

@bastelfreak
Copy link
Member

@fnoop can you add Ubilinux and Debian 9 to the metadata.json? Are you also interested in adding Ubilinux to facterdb? This is a gem with a list of mocked facts. This is heavily used for our unit testing (without that we can't test for Ubilinux).

@bastelfreak bastelfreak added the needs-work not ready to merge just yet label Mar 3, 2018
@bastelfreak
Copy link
Member

We should also add debian 9 to the acceptance test matrix if this is now working.

@bastelfreak
Copy link
Member

@fnoop can you please rebase?

@wyardley
Copy link
Collaborator

Closing via #1200; thanks for the contribution.

@fnoop
Copy link
Contributor Author

fnoop commented Mar 27, 2018

Apologies wasn't able to find time to rebase and finish this off, thanks for doing it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase needs-work not ready to merge just yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants