adding support for proxy_cache_bypass and proxy_cache_lock #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add tests for this? |
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Sep 13, 2019
…#1150) * adding support for proxy_cache_bypass and proxy_cache_lock * adding tests and restrict proxy_cache_lock to enum
ceonizm
added a commit
to ceonizm/puppet-nginx
that referenced
this pull request
Feb 7, 2020
…#1150) * adding support for proxy_cache_bypass and proxy_cache_lock * adding tests and restrict proxy_cache_lock to enum
ceonizm
pushed a commit
to ceonizm/puppet-nginx
that referenced
this pull request
Feb 7, 2020
adding support for include directive in map (voxpupuli#1149) * adding support for include directive in map * change param name includes to include_files to keep naming consistent with the other manifests adding test to ensure empty value , single and multiple inclusions works correctly * fix rubocop offenses adding support for proxy_cache_bypass and proxy_cache_lock (voxpupuli#1150) * adding support for proxy_cache_bypass and proxy_cache_lock * adding tests and restrict proxy_cache_lock to enum modifié : manifests/resource/location.pp modifié : manifests/resource/map.pp modifié : manifests/resource/server.pp modifié : spec/defines/resource_location_spec.rb modifié : spec/defines/resource_map_spec.rb modifié : templates/conf.d/map.erb modifié : templates/server/locations/proxy.erb
ceonizm
added a commit
to ceonizm/puppet-nginx
that referenced
this pull request
Feb 7, 2020
…nd directives adding documentation comments adding support for include directive in map (voxpupuli#1149) * adding support for include directive in map * change param name includes to include_files to keep naming consistent with the other manifests adding test to ensure empty value , single and multiple inclusions works correctly * fix rubocop offenses adding support for proxy_cache_bypass and proxy_cache_lock (voxpupuli#1150) * adding support for proxy_cache_bypass and proxy_cache_lock * adding tests and restrict proxy_cache_lock to enum fixing access_log, adding error_log and adding tests access_log: adding format_log to stay consistent with server declaration: when using it just disable logging, error_log: adding error_level to be able to set a different error level per location if needed); passing off disable the error_log changing type to Optional[Variant[Array, String]] for access_log & error_log to handle multiple declaration changing type to Optional[Variant[Array, String]] for access_log & error_log to handle multiple declaration
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
…#1150) * adding support for proxy_cache_bypass and proxy_cache_lock * adding tests and restrict proxy_cache_lock to enum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in previous PR (#1145) I've splitted features in multiples branches and PR:
Hello,
As I needed to use proxy_cache_bypass and proxy_cache_lock in my project, I've added it to the module.
Hope it helps.
Best regards
François.