Remove 'Optional' for resources with default settings #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eps the defaults)
ekohl
approved these changes
Oct 3, 2017
|
Are the acceptance tests failing in |
|
Looked like voxpupuli/beaker-rspec@6809f32 fixed it. |
|
Technically, it is possible to set undef in hiera (though not directly from the DSL). Not sure worth re-allowing this, though, as it could cause confusion in terms of how to use the module. |
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Sep 13, 2019
Remove 'Optional' for resources with default settings
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
Remove 'Optional' for resources with default settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1128, but basically, having default settings for Optional params gives some unexpected results (because passing in undef gives you the default vs. setting undef)