fix lint warnings #1115
Merged
fix lint warnings #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyardley
reviewed
Aug 29, 2017
manifests/resource/mailhost.pp
Outdated
| @@ -1,5 +1,7 @@ | |||
| # define: nginx::resource::mailhost | |||
| # | |||
| # lint:ignore:140chars | |||
| # | |||
There was a problem hiding this comment.
Can we just wrap these lines @ 140 char rather than ignoring the lint warnings? I realize it's just docs, but...
If you indent the following line one more space
# blah blah
# blah
it will get continued as one lines in the YARD doc, I think. Also, we'll switch to Puppet strings for param docs at some point anyway.
manifests/resource/location.pp
Outdated
| @@ -251,7 +251,7 @@ | |||
| # Only try to manage these files if they're the default one (as you presumably | |||
| # usually don't want the default template if you're using a custom file. | |||
|
|
|||
| if $ensure == present and $fastcgi != undef and !defined(File[$fastcgi_params]) and $fastcgi_params == "${::nginx::conf_dir}/fastcgi.conf" { | |||
| if $ensure == present and $fastcgi != undef and !defined(File[$fastcgi_params]) and $fastcgi_params == "${::nginx::conf_dir}/fastcgi.conf" { # lint:ignore:140chars | |||
There was a problem hiding this comment.
Can this conditional just be broken up into multiple lines as well?
|
Awesome. I squash-merged it rather than making you squash the commits. Thanks for the contribution. |
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Sep 13, 2019
* fix lint warnings
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
* fix lint warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.