Bump puppetlabs-concat, puppetlabs-stdlib and Puppet minimum versions #1081
Conversation
|
stdlib dependencty would need to be bumped to 4.13.1 too Do you need the updated concat module for something specific? |
tdevelioglu
force-pushed
the
bump_puppetlabs_concat_dependency
branch
2 times, most recently
from
640b383 to
9c38ff9
Compare
|
So maybe we should wait that the puppetlabs-concat PR is merged and released, and then bump the dependency to the version including the changes? |
|
It's partially merged (and released). The final commit is still pending, however. Sure, we can wait until it's finalized. |
juniorsysadmin
changed the title
|
@yastupin would it be wise to just bump it to 4.0.0 straight away (since we're bumping the puppet requirement to 4.7 anyway) ? (also see: https://github.com/puppetlabs/puppetlabs-concat/blob/master/CHANGELOG.md) |
tdevelioglu
force-pushed
the
bump_puppetlabs_concat_dependency
branch
from
9c38ff9 to
c328985
Compare
yastupin
dismissed
their stale review
need another reviewer as I'm not sure I get the point
|
Hello folks any change this can get merged? |
tdevelioglu
force-pushed
the
bump_puppetlabs_concat_dependency
branch
from
c328985 to
f8aeb28
Compare
This bumps the dependency on puppetlabs-concat to v3.0.0 and raises the minimum versions of the following dependencies to match: * puppet: 4.6.1 -> 4.7.0 * puppetlabs-stdlib: 4.6.0 -> 4.13.1
tdevelioglu
force-pushed
the
bump_puppetlabs_concat_dependency
branch
from
f8aeb28 to
a70d92d
Compare
|
I don't really see a point in not merging this, since it's just a metadata change. Let's fix things later if there's something wrong with it... |
…ncat_dependency Bump puppetlabs-concat, puppetlabs-stdlib and Puppet minimum versions
…ncat_dependency Bump puppetlabs-concat, puppetlabs-stdlib and Puppet minimum versions
This bumps the dependency on puppetlabs-concat to v3.0.0 and raises the minimum versions of the following dependencies to match: