auth_basic lines appearing in SSL vhost header when they shouldn't #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfryman
pushed a commit
that referenced
this pull request
Aug 1, 2013
auth_basic lines appearing in SSL vhost header when they shouldn't
|
🤘 |
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Oct 23, 2017
auth_basic lines appearing in SSL vhost header when they shouldn't
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had nginx crashing on startup because there were some malformed lines about
auth_basicin the configuration for a vhost using SSL, even though I hadn't specified anything to do with basic auth in Puppet.Turns out that
vhost_header.erbandvhost_ssl_header.erbuse a different syntax to test if@auth_basicis set, so I changed the latter to match the former, and it worked.Possibly related to #100.