Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Ubuntu 16.04? #935

Closed
lkthomas opened this issue Oct 19, 2016 · 7 comments
Closed

Support for Ubuntu 16.04? #935

lkthomas opened this issue Oct 19, 2016 · 7 comments

Comments

@lkthomas
Copy link

Is this module support Ubuntu 16.04?

@bastelfreak
Copy link
Member

Hi @lkthomas, we recently migrated this module in our namespace. Currently we try to work our-self through the open issues and PRs. Right now we havn't tested Ubuntu 16.04, but we are looking for volunteers to help out. Are you able to test the module on Ubuntu16.04 or write spec/acceptance tests for it?

@wyardley
Copy link
Collaborator

16.04 is now in the available options after the recent modulesync bump. I'll try to run the current acceptance tests about it.
@lkthomas: It should work, and so you're welcome to try it and let us know if you run into any problems. I'll try to add it to metadata.json when we've validated that it works.

@jarro2783
Copy link

I have used it on Ubuntu 16.04 without any issues.

@wyardley
Copy link
Collaborator

#951 addresses a few small points (adds it in metadata.json as supported, and adds it to the array of codenames that are looked for in params; this means that repos will now be managed where they weren't before. This also resolves an acceptance test problem with 16.04.

#954 should address some bootstrapping issues with acceptance tests for this platform. So, it should sort of work already, but the next release should improve support.

@jarro2783
Copy link

The issues behind #951 or #954 didn't make a difference for us, because we use bundler to package the puppet version with dependencies that we need, and r10k to install all the external puppet modules. The puppet code seems to work as far as our setup goes, since we just ran it on Ubuntu 16.04 and didn't have any issues.

So I can't comment on any of the meta packaging type stuff, but the module itself seems fine.

@wyardley
Copy link
Collaborator

@jarro2783: the difference mostly is that manage_repos wouldn't have been enabled unless explicitly set, so a pretty small thing, but would have caused slightly different behavior from the current expectations. The other ticket just fixed problems with acceptance tests, so yes, doesn't affect end-users. I'm going to close out this ticket as soon as those PRs get merged.

@wyardley wyardley reopened this Oct 30, 2016
@wyardley
Copy link
Collaborator

wyardley commented Nov 1, 2016

I'm going to close this for now. Let me know if any other issues come up with 16.

@wyardley wyardley closed this as completed Nov 1, 2016
cegeka-jenkins pushed a commit to cegeka/puppet-nginx that referenced this issue Sep 13, 2019
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this issue Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants