add_header doesn't support headers properly

[Spechal]

The add_header call needs to wrap things in quotes or nginx freaks out.

https://github.com/jfryman/puppet-nginx/blob/56e1c591bf5bfd06c34782c66953b3bc4b10fafa/templates/vhost/vhost_ssl_header.erb#L134

https://github.com/jfryman/puppet-nginx/blob/56e1c591bf5bfd06c34782c66953b3bc4b10fafa/templates/vhost/vhost_header.erb#L131

[3flex]

Do you have example error output from nginx? nginx documentation doesn't mention quotes being required.

[Spechal]

I can generate one. If you have a header with a space in the content, nginx will generate an invalid arguments error.

-Travis

Sent from my iPhone

On May 13, 2016, at 9:38 AM, Matthew Haughton [email protected] wrote:

Do you have example error output from nginx? nginx documentation doesn't mention quotes being required.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

[3flex]

Ah, that makes sense.

I've restarted the failed build, it should pass now. I'll go ahead and merge then. Thanks!