Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

white space #742

Closed
gerases opened this issue Jan 20, 2016 · 7 comments
Closed

white space #742

gerases opened this issue Jan 20, 2016 · 7 comments

Comments

@gerases
Copy link
Contributor

gerases commented Jan 20, 2016

Hi,

I see a lot of untrimmed whitespace in the resulting nginx vhosts. For example:

ssl_prefer_server_ciphers on;







index  index.html index.htm index.php;

Was wondering if you were aware of it and whether a fix is coming.

Thanks!!

@jfryman
Copy link
Contributor

jfryman commented Jan 20, 2016

@gerases Pull requests are always accepted! TIA! 🙇

@gerases
Copy link
Contributor Author

gerases commented Jan 20, 2016

​Hi James,

I can do a pull request, but I'm not sure if what I've fixed is a
comprehensive​e fix. I can submit what I have and you extrapolate from
there?

Thanks,
Sergei

On Wed, Jan 20, 2016 at 3:05 PM, James Fryman [email protected]
wrote:

@gerases https://github.com/gerases Pull requests are always accepted!
TIA! [image: 🙇]


Reply to this email directly or view it on GitHub
#742 (comment)
.

@3flex
Copy link
Contributor

3flex commented Feb 11, 2016

@gerases even if it's not comprehensive, it will still be an improvement, so don't be scared to submit something that doesn't necessarily cover all cases!

@3flex
Copy link
Contributor

3flex commented Aug 30, 2016

Closing this as it's not an issue that affects the functionality of the module. PRs to improve the situation would be welcome!

@3flex 3flex closed this as completed Aug 30, 2016
@igalic
Copy link
Contributor

igalic commented Aug 31, 2016

@3flex imo, it affects the usability of the module, and that, definitely is an issue that needs to be addressed.

@wyardley
Copy link
Collaborator

I put in a PR that's a first pass at cleaning up the spacing a little: #891

bastelfreak added a commit that referenced this issue Sep 29, 2016
try to improve spacing in generated configs (Issue #742)
@igalic
Copy link
Contributor

igalic commented Oct 4, 2016

with #891 i'm going to close this issue for now

@igalic igalic closed this as completed Oct 4, 2016
darken99 pushed a commit to darken99/puppet-nginx that referenced this issue Oct 13, 2016
cegeka-jenkins pushed a commit to cegeka/puppet-nginx that referenced this issue Sep 13, 2019
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this issue Oct 19, 2020
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this issue Oct 19, 2020
try to improve spacing in generated configs (Issue voxpupuli#742)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants