Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper integer quoting to resolve futureparser issues #512

Closed
jowrjowr opened this issue Dec 4, 2014 · 3 comments
Closed

Proper integer quoting to resolve futureparser issues #512

jowrjowr opened this issue Dec 4, 2014 · 3 comments

Comments

@jowrjowr
Copy link

jowrjowr commented Dec 4, 2014

Could you please single-quote all the integers in config.pp?

This module does not work with parser = future unless I do that (it otherwise works fine), and this change is consistent with what the puppet style guide wants:

https://docs.puppetlabs.com/guides/style_guide.html#quoting

This is really easy to do - does it need a pull request, or is this sufficient?

@3flex
Copy link
Contributor

3flex commented Dec 4, 2014

Hi @jowrjowr in master it looks like all integers are single-quoted already. Can you tell me which version of the module you're using? Also what errors you see?

@jowrjowr
Copy link
Author

jowrjowr commented Dec 4, 2014

I was trying 0.0.10 and then 0.2.0 which is current for puppetforge.

I've historically avoided using master for the nginx module because you've
used that as a development spot in the past, but if the single quoting is
fixed in master then all is well. It just needs to propagate down to what
gets distributed via forge. This was a really small fix

I looked for active issues but didn't think to actually check master code
itself.

The module otherwise works perfectly fine with the future parser. As well
as gentoo on 0.2.0, for that matter. Please don't wreck gentoo support :D

Thanks!

On Thu, Dec 4, 2014 at 4:35 AM, Matthew Haughton [email protected]
wrote:

Hi @jowrjowr https://github.com/jowrjowr in master it looks like all
integers are single-quoted already. Can you tell me which version of the
module you're using? Also what errors you see?


Reply to this email directly or view it on GitHub
#512 (comment)
.

@3flex
Copy link
Contributor

3flex commented Dec 4, 2014

Cheers - this was fixed in #509.

And we'll definitely try and keep intact all current OS support!

@3flex 3flex closed this as completed Dec 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants