You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Could you please single-quote all the integers in config.pp?
This module does not work with parser = future unless I do that (it otherwise works fine), and this change is consistent with what the puppet style guide wants:
Hi @jowrjowr in master it looks like all integers are single-quoted already. Can you tell me which version of the module you're using? Also what errors you see?
I was trying 0.0.10 and then 0.2.0 which is current for puppetforge.
I've historically avoided using master for the nginx module because you've
used that as a development spot in the past, but if the single quoting is
fixed in master then all is well. It just needs to propagate down to what
gets distributed via forge. This was a really small fix
I looked for active issues but didn't think to actually check master code
itself.
The module otherwise works perfectly fine with the future parser. As well
as gentoo on 0.2.0, for that matter. Please don't wreck gentoo support :D
Thanks!
On Thu, Dec 4, 2014 at 4:35 AM, Matthew Haughton [email protected]
wrote:
Hi @jowrjowrhttps://github.com/jowrjowr in master it looks like all
integers are single-quoted already. Can you tell me which version of the
module you're using? Also what errors you see?
—
Reply to this email directly or view it on GitHub #512 (comment)
.
Could you please single-quote all the integers in config.pp?
This module does not work with parser = future unless I do that (it otherwise works fine), and this change is consistent with what the puppet style guide wants:
https://docs.puppetlabs.com/guides/style_guide.html#quoting
This is really easy to do - does it need a pull request, or is this sufficient?
The text was updated successfully, but these errors were encountered: