Service resource name conflicts with system service

[fnoop]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 5.2
• Ruby: 2.3.3
• Distribution: Debian 9
• Module version: master

How to reproduce (e.g Puppet code you use)

class { 'nginx':
        service_manage  => true,
        service_name    => "maverick-nginx",
    }

service { "nginx":
 ensure => stopped,
 enable => false
}

What are you seeing

Because the puppet-nginx service manifest calls service { 'nginx':, if you want to use puppet-nginx to manage a custom nginx service (eg. 'maverick-nginx' in this instance), you cannot also control the default system nginx service (eg. to turn it off as in the fragment above). This is a perfectly valid scenario.

Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Resource Statement, Cannot alias Service[system-nginx] to ["nginx"] at /srv/maverick/software/maverick/manifests/init.pp:205; resource ["Service", "nginx"] already declared at /srv/maverick/software/maverick/manifests/puppet-modules/nginx/manifests/service.pp:53 at /srv/maverick/software/maverick/manifests/init.pp:205:13  at /srv/maverick/software/maverick/manifests/maverick-modules/maverick_web/manifests/nginx.pp:26 on node maverick-up.home

What behaviour did you expect instead

Control of both services should be possible.