Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fastcgi_params file set to permission 770 by default #1002

Closed
jarro2783 opened this issue Jan 19, 2017 · 4 comments · Fixed by #1003
Closed

fastcgi_params file set to permission 770 by default #1002

jarro2783 opened this issue Jan 19, 2017 · 4 comments · Fixed by #1003
Assignees
@wyardley
Labels
needs-work not ready to merge just yet

Comments

@jarro2783
Copy link

For all versions of the Puppet module, the fastcgi_params file is set to permissions 770. This seems really weird to me. Since it is a normal file, it should be 644 like everything else.
@wyardley
Copy link
Collaborator

I'm not sure why that is, but I'm going to propose a PR to change fastcgi_params and uwsgi_params. I'll solicit some input before getting it approved to make sure there's not a reason for those permissions. I don't know why they're not world readable either, I don't think there should be anything sensitive in those files (maybe it's matching the permissions in some vendor-distributed version of the file?)

What's odd to me is that the permissions actually aren't 0770 on a system where I'm using this module...

@wyardley wyardley mentioned this issue Jan 20, 2017
Merged
@rnelson0 rnelson0 added the needs-work not ready to merge just yet label Jan 20, 2017
@jarro2783
Copy link
Author

Actually I noticed the same thing on one of our hosts. On a different host it is always 0770. Not sure why it is doing that.

@wyardley
Copy link
Collaborator

@jarro2783 Are you setup in such a way that you can test this PR? That said, if no one else sees a reason for the original permissions, I think this one is ready to merge.

@jarro2783
Copy link
Author

I can only test it against 0.5.0. I don't know how Puppet module spec tests are run, but I can at least verify that the output file has the right permissions on one of our hosts.

hunner added a commit that referenced this issue Jan 26, 2017
@hunner
Merge pull request #1003 from wyardley/fastcgi_params_permissions_fix
ff59837 
Permissions on fastcgi_params and uwsgi_params files (#1002)
cegeka-jenkins pushed a commit to cegeka/puppet-nginx that referenced this issue Sep 13, 2019
Permissions on fastcgi_params and uwsgi_params files (voxpupuli#1002)
04482f1
cegeka-jenkins pushed a commit to cegeka/puppet-nginx that referenced this issue Sep 13, 2019
@hunner
Merge pull request voxpupuli#1003 from wyardley/fastcgi_params_permis…
faf8d3f 
…sions_fix

Permissions on fastcgi_params and uwsgi_params files (voxpupuli#1002)
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this issue Oct 19, 2020
Permissions on fastcgi_params and uwsgi_params files (voxpupuli#1002)
eac3504
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this issue Oct 19, 2020
@hunner
Merge pull request voxpupuli#1003 from wyardley/fastcgi_params_permis…
28edcd4 
…sions_fix

Permissions on fastcgi_params and uwsgi_params files (voxpupuli#1002)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wyardley wyardley

Labels
needs-work not ready to merge just yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix permissions on fastcgi_params and uwsgi_params files (#1002)
3 participants
@jarro2783 @rnelson0 @wyardley