Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

puppet systemd 9 #266

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

puppet systemd 9 #266

wants to merge 6 commits into from

Conversation

jay7x
Copy link
Member

@jay7x jay7x commented Dec 14, 2024

  • modulesync 9.1.0
  • modulesync 9.2.0
  • Switch unit tests to CERN runner
  • modulesync 9.3.0
  • puppet/systemd: allow 8.x

@duritong
Copy link
Collaborator

Why are tests always failing?

@traylenator
Copy link
Collaborator

Why are tests always failing?

223) nftables::simplerule on rocky-9-x86_64 only IPv4 TCP traffic is expected to compile into a catalogue without dependency cycles
       Failure/Error: it { is_expected.to compile }
         error during compilation: Parameter enable failed on Service[firewalld]: Provider debian must have features 'maskable' to set 'enable' to 'mask' (file: /scratch/actions/actions-runner-2.305.0/instance14/_work/puppet-nftables/puppet-nftables/spec/fixtures/modules/nftables/manifests/init.pp, line: 267)
       # ./spec/defines/simplerule_spec.rb:150:in `block (5 levels) in <top (required)>'

This is when we get the wrong service provider "debian" and not "systemd'.

Thought we has some mocking somewhere to satisfy:

confine :true => Puppet::FileSystem.exist?('/proc/1/comm') && Puppet::FileSystem.read('/proc/1/comm').include?('systemd')

in the service systemd provider. Failing to find it.

@traylenator
Copy link
Collaborator

Thought we has some mocking somewhere to satisfy:

Yeah we seemed to have lost here:

65ed81b#diff-89eebfcbc0f14b6d989517837ca1e94fce4e2ce9a03233641cd936f2b8d2ed94

@traylenator traylenator mentioned this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants