-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for replication.enableMajorityReadConcern setting #544
Open
williamkorb
wants to merge
12
commits into
voxpupuli:master
Choose a base branch
from
williamkorb:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
69d172a
Working on adding support for replication.enableMajorityReadConcern s…
wkorb-mason 4da13f3
Added spec tests for replication.enableMajorityReadConcern.
williamkorb 8d2137d
Tweaked spec tests for replication.enableMajorityReadConcern.
williamkorb a8bc548
Tweaked spec tests for replication.enableMajorityReadConcern.
williamkorb c4cf016
Tweaked spec tests for replication.enableMajorityReadConcern.
williamkorb 33bb9c7
Tweaked spec tests for replication.enableMajorityReadConcern.
williamkorb 0f05438
Tweaked spec tests for replication.enableMajorityReadConcern.
williamkorb 201d1f2
Tweaked spec tests for replication.enableMajorityReadConcern.
williamkorb 3ad9de2
Tweaked template for replication.enableMajorityReadConcern.
williamkorb 93bc5b5
Tweaked template for replication.enableMajorityReadConcern.
williamkorb e280416
Tweaked spec tests for replication.enableMajorityReadConcern.
williamkorb a326d62
Updates for replication.enableMajorityReadConcern after PR comments.
williamkorb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make this non optional and default to true? That makes the code here and in the template easier to read.