This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
Avoid compilation failure with strict_variables=true #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When strict_variables is on and mcollective has yet to be installed, mco_version isn't defined, so referring to it here breaks compilation. The fix here uses a pattern used by puppetlabs-apt.
|
Hi. we're currently doing a modulesync in #314, this will fix your currently travis issues. Please rebase after that PR is merged. |
dhoppe
approved these changes
Oct 13, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
strict_variablesis on and mcollective has yet to be installed,mco_versionisn't defined, so referring to it here breaks compilation. The fix here uses a pattern used by puppetlabs-apt.Seeing as this is a very minor fix and testing Puppet modules is an art I'm totally unfamiliar with, I haven't changed any tests as part of this commit. I hope that's not too much of a problem.