Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed GPG server and instead get the key file itself. #247

Merged
1 commit merged into from
May 4, 2016

Conversation

abednarik
Copy link
Contributor

Please see Issue #191

I would like to ask why using 40 characters key was reverted in elasticsearch module? I can update both modules if it is useful, to avoid ap module warnings.

@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@electrical
Copy link

Hi,

regarding the short key is because of the use of an older apt module with PE 3.7.x which doesn't support the long key yet.
When i can drop that support i should be able to move to the long key.

@abednarik
Copy link
Contributor Author

Got it, thanks.

@jmkgreen
Copy link

What happened with this? Looks like it broke the build?

@abednarik
Copy link
Contributor Author

I think that failing test are not related to my commit. See here https://travis-ci.org/elastic/puppet-logstash/builds test are broken before this commit.

@elasticsearch-release
Copy link

Can one of the admins verify this patch?

@ghost ghost merged commit 65e175d into voxpupuli:master May 4, 2016
@ghost
Copy link

ghost commented May 4, 2016

Thanks! I brought this commit in through another PR, in order to trigger the new build/test system.

Cheers.

@abednarik abednarik deleted the remove_gpg_server branch May 5, 2016 00:41
@ghost ghost mentioned this pull request Jul 18, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants