Fix missing su line in default logrotate.conf on Ubuntu #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szponek
force-pushed
the
fix-default-logrotate-conf-on-ubuntu
branch
from
646f973
to
d26759f
Compare
bastelfreak
reviewed
Nov 26, 2017
manifests/params.pp
Outdated
| @@ -31,11 +31,16 @@ | |||
| } | |||
| } | |||
| 'Debian': { | |||
| $default_su_user = versioncmp($::operatingsystemmajrelease, '14.00') ? { | |||
There was a problem hiding this comment.
can you please use the new $facts[] hash instead of the topscope variable?
There was a problem hiding this comment.
Commit updated. Switched to $facts[] in both the line I added and the one for default su group that was already there.
|
Hi @szponek, thanks for the PR. Can you take a look at the used email address in your commit? It isn't associated with your github account. |
szponek
force-pushed
the
fix-default-logrotate-conf-on-ubuntu
branch
from
d26759f
to
208fe2d
Compare
|
Hi @bastelfreak - commit email fixed. Thank you for letting me know |
|
Thanks @szponek ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi voxpopuli team,
Default /etc/logrotate.conf on Ubuntu includes a line containing 'su root syslog', but this line is not present in default config produced by this module.
Although $su_group is properly set to 'syslog' in manifests/config.pp, $su_user stays undefined and the condition in templates/etc/logrotate.conf.erb:46 is not met.
This commit makes sure $su_user is set properly on Ubuntu resulting in missing line being present in default config file.
Cheers
Grzegorz